Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rename try methods to strict #5477

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fix: Rename try methods to strict #5477

merged 2 commits into from
Jul 15, 2022

Conversation

jeremyyeo
Copy link
Contributor

@jeremyyeo jeremyyeo commented Jul 15, 2022 •
edited
Loading

Partially resolves #5475

Description

Renamed:

  • try_set → set_strict
  • try_zip → zip_strict

Checklist

@jeremyyeo jeremyyeo requested review from a team as code owners July 15, 2022 11:11
@jeremyyeo jeremyyeo requested review from gshank and emmyoop July 15, 2022 11:11
@cla-bot cla-bot bot added the cla:yes label Jul 15, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

emmyoop
emmyoop approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning this up @jeremyyeo!

@emmyoop emmyoop added the backport 1.2.latest This PR will be backported to the 1.2.latest branch label Jul 15, 2022
@emmyoop emmyoop merged commit 3f37928 into 1.2.latest Jul 15, 2022
@emmyoop emmyoop deleted the rename-strict-mode branch July 15, 2022 13:17
emmyoop pushed a commit that referenced this pull request Jul 15, 2022
@jeremyyeo @emmyoop
Fix: Rename try methods to strict (#5477)
f8621f4 
* rename strict methods

* add changelog
@emmyoop emmyoop mentioned this pull request Jul 15, 2022
Merged
6 tasks
@emmyoop emmyoop removed the backport 1.2.latest This PR will be backported to the 1.2.latest branch label Jul 15, 2022
emmyoop added a commit that referenced this pull request Jul 15, 2022
@emmyoop @jeremyyeo
Fix: Rename try methods to strict (#5477) (#5478)
e03d35a 
* rename strict methods

* add changelog

Co-authored-by: Jeremy Yeo <jeremyyeo@users.noreply.github.com>
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
@emmyoop @jeremyyeo
Fix: Rename try methods to strict (dbt-labs#5477) (dbt-labs#5478)
608ae7e 
* rename strict methods

* add changelog

Co-authored-by: Jeremy Yeo <jeremyyeo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremyyeo @emmyoop