Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-700] [Bug] Logging tons of asterisks for sensitive env vars #5518

Merged
merged 3 commits into from Jul 27, 2022

Conversation

Goodkat
Copy link
Contributor

@Goodkat Goodkat commented Jul 23, 2022

Created PR in response to this issue:
CT-700 [Bug] Logging tons of asterisks when sensitive env vars are missing
#5312

resolves #

Description

Checklist

@Goodkat Goodkat requested a review from a team July 23, 2022 19:28
@Goodkat Goodkat requested a review from a team as a code owner July 23, 2022 19:28
@cla-bot
Copy link

cla-bot bot commented Jul 23, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @Goodkat

@Goodkat
Copy link
Contributor Author

Goodkat commented Jul 26, 2022

Hello Team,
This is my first contribution to this repo. I see all the tests have been passed.
Can anyone review and approve the changes then?
Thanks

@lostmygithubaccount lostmygithubaccount added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering and removed ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jul 26, 2022
@jtcohen6 jtcohen6 added Team:Language ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jul 27, 2022
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodkat thats so much for the quick turn around with the contribution! I just have a small request regarding the changelog body.

.changes/unreleased/Fixes-20220723-215330.yaml Outdated Show resolved Hide resolved
@Goodkat Goodkat requested a review from emmyoop July 27, 2022 15:15
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for the contribution!

@emmyoop emmyoop merged commit c3891d7 into dbt-labs:main Jul 27, 2022
@Goodkat Goodkat deleted the issue/ct-700 branch July 27, 2022 20:16
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
…labs#5518)

* [CT-700] [Bug] Logging tons of asterisks when sensitive env vars are missing

* [CT-700][Bug] Added changelog entry

* Updated the changelog body message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-700] [Bug] Logging tons of asterisks when sensitive env vars are missing
4 participants