Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use MethodName.File when value ends with .csv #5581

Merged
merged 3 commits into from
Aug 1, 2022
Merged

use MethodName.File when value ends with .csv #5581

merged 3 commits into from
Aug 1, 2022

Conversation

Goodkat
Copy link
Contributor

@Goodkat Goodkat commented Jul 29, 2022 •
edited
Loading

resolves #5578

Description

Following the thread here
Add support for selector support .csv files when using selector with dbt seed.

Checklist

@Goodkat Goodkat requested review from a team and ChenyuLInx July 29, 2022 15:13
@cla-bot cla-bot bot added the cla:yes label Jul 29, 2022
@Goodkat Goodkat requested a review from a team as a code owner July 29, 2022 15:34
@Goodkat Goodkat requested a review from emmyoop July 29, 2022 15:34
@jtcohen6 jtcohen6 added Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jul 30, 2022
ChenyuLInx
ChenyuLInx approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That was fast @Goodkat

@emmyoop emmyoop removed their request for review August 1, 2022 14:38
@ChenyuLInx ChenyuLInx merged commit 26b33e6 into dbt-labs:main Aug 1, 2022
@ChenyuLInx
Copy link
Contributor

@Goodkat Thanks for adding this!!!

@Goodkat Goodkat deleted the issue/5578 branch August 1, 2022 21:39
VersusFacit pushed a commit that referenced this pull request Sep 5, 2022
@Goodkat @VersusFacit
use MethodName.File when value ends with .csv (#5581)
8d93c78 
* [CT-953] [Feature] Support for .csv files when using file selectors(for seed)

* Added Changelog entry for issue-5578

* Added Unit tests
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
@Goodkat
use MethodName.File when value ends with .csv (dbt-labs#5581)
3a0b89d 
* [CT-953] [Feature] Support for .csv files when using file selectors(for seed)

* Added Changelog entry for issue-5578

* Added Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-953] [Feature] Support for .csv files when using file selectors(for seed)
3 participants
@Goodkat @ChenyuLInx @jtcohen6