Do not render metrics description field when doing render_data #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
jtcohen6
added
the
backport 1.2.latest
ChenyuLInx
approved these changes
Aug 4, 2022
gshank
added
backport 1.2.latest
github-actions bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
(cherry picked from commit eb72dbf)
SOVALINUX
pushed a commit
to SOVALINUX/dbt-core
that referenced
this pull request
Aug 12, 2022
…abs#5603) (dbt-labs#5619) (cherry picked from commit eb72dbf) Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5585
Description
The addition of a line of code to skip rendering the metrics "sql" attribute caused the "description" attribute to be rendered at the wrong time with the wrong context.
Note: still needs tests.
Checklist
changie newto create a changelog entry