Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos of comments in core/dbt/adapters/ #5693

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix typos of comments in core/dbt/adapters/ #5693

merged 1 commit into from
Sep 27, 2022

Conversation

yoiki
Copy link
Contributor

@yoiki yoiki commented Aug 22, 2022 •
edited
Loading

resolves #5690

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 22, 2022
@yoiki yoiki marked this pull request as ready for review August 22, 2022 10:45
@yoiki yoiki requested review from a team as code owners August 22, 2022 10:45
@jtcohen6 jtcohen6 added Team:Adapters Issues designated for the adapter area of the code ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Aug 22, 2022
colin-rogers-dbt
colin-rogers-dbt approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McKnight-42 McKnight-42 reopened this Sep 26, 2022
@McKnight-42
Copy link
Contributor

closing and reopening to re-rigger checks

@colin-rogers-dbt colin-rogers-dbt merged commit 59744f1 into dbt-labs:main Sep 27, 2022
@yoiki yoiki deleted the fix_typo_in_docstring branch September 28, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42 McKnight-42 was automatically assigned from dbt-labs/adapters

@Fleid Fleid Awaiting requested review from Fleid Fleid was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1063] [Bug] Small typos in core/dbt/adapters/
4 participants
@yoiki @McKnight-42 @colin-rogers-dbt @jtcohen6