New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tmp file after test passed #5749
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bertjan Broeksema.
|
I've added the email address which I used to sign the CLA to my github account. Do I need to to anything else to make the check pass? |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbroeksema Could you add a changelog entry? We don't usually require one for changes to tests only, but it's also our way of giving you credit for your contribution :)
@jtcohen6 done. |
* Remove tmp file after test passed * Add changelog entry
resolves 5631
Description
This pull request improves a test case by removing a tmp file that is created during test execution. The resolution has been verified by following the steps to reproduce as described in: #5631 and verifying that after this fix the file is indeed removed. This PR adds the rm_file from
dbt.tests.utils
to remove the specific file.Checklist
changie new
to create a changelog entryI haven't add a changelog entry yet, does that make sense for fixing a test?