Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmp file after test passed #5749

Merged
merged 2 commits into from Sep 9, 2022

Conversation

bbroeksema
Copy link
Contributor

@bbroeksema bbroeksema commented Aug 31, 2022

resolves 5631

Description

This pull request improves a test case by removing a tmp file that is created during test execution. The resolution has been verified by following the steps to reproduce as described in: #5631 and verifying that after this fix the file is indeed removed. This PR adds the rm_file from dbt.tests.utils to remove the specific file.

Checklist

I haven't add a changelog entry yet, does that make sense for fixing a test?

@cla-bot
Copy link

cla-bot bot commented Aug 31, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bertjan Broeksema.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@bbroeksema
Copy link
Contributor Author

I've added the email address which I used to sign the CLA to my github account. Do I need to to anything else to make the check pass?

@gshank
Copy link
Contributor

gshank commented Sep 7, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Sep 7, 2022
@cla-bot
Copy link

cla-bot bot commented Sep 7, 2022

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbroeksema Could you add a changelog entry? We don't usually require one for changes to tests only, but it's also our way of giving you credit for your contribution :)

@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Sep 7, 2022
@bbroeksema
Copy link
Contributor Author

@jtcohen6 done.

@gshank gshank merged commit e3f8275 into dbt-labs:main Sep 9, 2022
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
* Remove tmp file after test passed

* Add changelog entry
@bbroeksema bbroeksema deleted the CT-1016/tmp_file_cleanup branch October 24, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants