Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altering Window Metric Attribute To Match Freshness Tests #5793

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Altering Window Metric Attribute To Match Freshness Tests #5793

merged 7 commits into from
Sep 9, 2022

Conversation

callum-mcdata
Copy link
Contributor

resolves #5722

Description

This is the second PR for this particular set of functionality. @joellabes proved his power again and pointed out that window should probably match the format we use in freshness tests.

However the TimePeriod and Time classes defined for freshness tests don't match the current capabilities of Metrics.

Implementation

  • Creation of MetricTime
  • Creation of MetricTimePeriod (set to day, week, month, year)
  • Updating files and tests to denote this new method

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@ChenyuLInx ChenyuLInx self-requested a review September 9, 2022 18:21
@callum-mcdata callum-mcdata marked this pull request as ready for review September 9, 2022 18:28
@callum-mcdata callum-mcdata requested review from a team as code owners September 9, 2022 18:28
ChenyuLInx
ChenyuLInx approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChenyuLInx ChenyuLInx merged commit b26280d into main Sep 9, 2022
@ChenyuLInx ChenyuLInx deleted the remaking_window_config branch September 9, 2022 23:33
@jtcohen6 jtcohen6 mentioned this pull request Sep 12, 2022
Closed
1 task
josephberni pushed a commit to Gousto/dbt-core that referenced this pull request Sep 16, 2022
@callum-mcdata @josephberni
Altering Window Metric Attribute To Match Freshness Tests (dbt-labs#5793
26e042e 
)

* changing window spec

* more updates

* adding to v7 json?

* chenyu rules

* updating for formatting

* updating metric deferral test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@callum-mcdata @ChenyuLInx