Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pathspec requirement from ~=0.9.0 to >=0.9,<0.11 in /core #5917

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2022

Updates the requirements on pathspec to permit the latest version.

Release notes

Sourced from pathspec's releases.

v0.10.1

Release v0.10.1. See CHANGES.rst.

Changelog

Sourced from pathspec's changelog.

0.10.1 (2022-09-02)

Bug fixes:

  • Fix documentation on pathspec.pattern.RegexPattern.match_file().
  • Issue [#60](https://github.com/cpburnz/python-pathspec/issues/60)_: Remove redundant wheel dep from pyproject.toml.
  • Issue [#61](https://github.com/cpburnz/python-pathspec/issues/61)_: Dist failure for Fedora, CentOS, EPEL.
  • Issue [#62](https://github.com/cpburnz/python-pathspec/issues/62)_: Since version 0.10.0 pure wildcard does not work in some cases.

Improvements:

  • Restore support for legacy installations using setup.py. See Issue [#61](https://github.com/cpburnz/python-pathspec/issues/61)_.

.. _Issue [#60](https://github.com/cpburnz/python-pathspec/issues/60): cpburnz/python-pathspec#60 .. _Issue [#61](https://github.com/cpburnz/python-pathspec/issues/61): cpburnz/python-pathspec#61 .. _Issue [#62](https://github.com/cpburnz/python-pathspec/issues/62): cpburnz/python-pathspec#62

0.10.0 (2022-08-30)

Major changes:

  • Dropped support of EOL Python 2.7, 3.5, 3.6. See Issue [#47](https://github.com/cpburnz/python-pathspec/issues/47)_.
  • The gitwildmatch pattern dir/* is now handled the same as dir/. This means dir/* will now match all descendants rather than only direct children. See Issue [#19](https://github.com/cpburnz/python-pathspec/issues/19)_.
  • Added pathspec.GitIgnoreSpec class (see new features).
  • Changed build system to pyproject.toml_ and build backend to setuptools.build_meta_ which may have unforeseen consequences.
  • Renamed GitHub project from python-path-specification_ to python-pathspec. See Issue [#35](https://github.com/cpburnz/python-pathspec/issues/35).

API changes:

  • Deprecated: pathspec.util.match_files() is an old function no longer used.
  • Deprecated: pathspec.match_files() is an old function no longer used.
  • Deprecated: pathspec.util.normalize_files() is no longer used.
  • Deprecated: pathspec.util.iter_tree() is an alias for pathspec.util.iter_tree_files().
  • Deprecated: pathspec.iter_tree() is an alias for pathspec.util.iter_tree_files().
  • Deprecated: pathspec.pattern.Pattern.match() is no longer used. Use or implement pathspec.pattern.Pattern.match_file().

New features:

  • Added class pathspec.gitignore.GitIgnoreSpec (with alias pathspec.GitIgnoreSpec) to implement gitignore behavior not possible with standard PathSpec class. The particular gitignore behavior implemented is prioritizing patterns matching the file directly over matching an ancestor directory.

Bug fixes:

  • Issue [#19](https://github.com/cpburnz/python-pathspec/issues/19)_: Files inside an ignored sub-directory are not matched.
  • Issue [#41](https://github.com/cpburnz/python-pathspec/issues/41)_: Incorrectly (?) matches files inside directories that do match.
  • Issue [#51](https://github.com/cpburnz/python-pathspec/issues/51)_: Refactor deprecated unittest aliases for Python 3.11 compatibility.

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [pathspec](https://github.com/cpburnz/python-pathspec) to permit the latest version.
- [Release notes](https://github.com/cpburnz/python-pathspec/releases)
- [Changelog](https://github.com/cpburnz/python-pathspec/blob/master/CHANGES.rst)
- [Commits](cpburnz/python-pathspec@v0.9.0...v0.10.1)

---
updated-dependencies:
- dependency-name: pathspec
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 23, 2022 00:06
@dependabot dependabot bot added dependencies Changes to the version of dbt dependencies python Pull requests that update Python code labels Sep 23, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 23, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop
Copy link
Member

emmyoop commented Sep 23, 2022

@leahwicz Do you know of a way to control flow of actions that are not dependent on each other? Can we say "Run workflow 5 last"?

Basically, the does a changelog exist action completes (with a failure and posts the above comment) before we add the new changelog for the bot PR. The does a changelog exist action runs again after the new changelog yaml file gets committed and passes. So this is not a true bug or actual problem. More general hygiene.

@leahwicz
Copy link
Contributor

To my knowledge (not saying it isn't possible though), since workflows are just listening for their event type to fire, there is no way to say don't run if workflow x is also running. You could try adding some logic to just not post the changelog message to dependency labeled PRs if we really wanted to

Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iknox-fa
Copy link
Contributor

@emmyoop I assume I can go ahead and merge this right? The comments above aren't a blocker are they?

@emmyoop
Copy link
Member

emmyoop commented Sep 28, 2022

@iknox-fa - yes! My question was not meant to be blocking. Nothing wrong with this PR, it just annoys me that every dependabot PR posts the "There's no changelog..." comment.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2022

A newer version of pathspec exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@leahwicz leahwicz merged commit 9297e4d into main Nov 16, 2022
@leahwicz leahwicz deleted the dependabot/pip/core/pathspec-gte-0.9-and-lt-0.11 branch November 16, 2022 03:02
@leahwicz
Copy link
Contributor

Backporting this to just test something. Not really going to backport

github-actions bot pushed a commit that referenced this pull request Nov 29, 2022
* Update pathspec requirement from ~=0.9.0 to >=0.9,<0.11 in /core

Updates the requirements on [pathspec](https://github.com/cpburnz/python-pathspec) to permit the latest version.
- [Release notes](https://github.com/cpburnz/python-pathspec/releases)
- [Changelog](https://github.com/cpburnz/python-pathspec/blob/master/CHANGES.rst)
- [Commits](cpburnz/python-pathspec@v0.9.0...v0.10.1)

---
updated-dependencies:
- dependency-name: pathspec
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add automated changelog yaml from template for bot PR

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
(cherry picked from commit 9297e4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3.latest cla:yes dependencies Changes to the version of dbt dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants