Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mashumaro[msgpack] from 3.0.4 to 3.1 in /core #6108

Merged
merged 4 commits into from Nov 30, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 20, 2022

Bumps mashumaro[msgpack] from 3.0.4 to 3.1.

Release notes

Sourced from mashumaro[msgpack]'s releases.

v3.1

Changes

  • Added support for Python 3.11
  • Added support for typing.Self and typing_extensions.Self
  • In addition to from_dict and to_dict, methods in other mixins can also be compiled now
  • Increased speed of serialization and deserialization in MessagePack when using DataClassMessagePackMixin:
    • Removed the implicit inclusion of the ADD_DIALECT_SUPPORT config option when using DataClassMessagePackMixin
    • Methods from_msgpack and to_msgpack are now compiled
  • Added DataClassORJSONMixin to use a third-party orjson library that will handle supported data types by itself
    • Added new orjson_options config option to change default options passing to orjson.dumps method
    • Methods to_jsonb and to_json have orjson_options keyword argument to override the default options
  • Added support for TOML format using DataClassTOMLMixin
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 20, 2022 00:07
@dependabot dependabot bot added dependencies Changes to the version of dbt dependencies python Pull requests that update Python code labels Oct 20, 2022
@cla-bot cla-bot bot added the cla:yes label Oct 20, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@joshuataylor
Copy link
Contributor

This is blocking python 3.11 upgrades.

dependabot bot and others added 2 commits November 27, 2022 17:32
Bumps [mashumaro[msgpack]](https://github.com/Fatal1ty/mashumaro) from 3.0.4 to 3.1.
- [Release notes](https://github.com/Fatal1ty/mashumaro/releases)
- [Commits](Fatal1ty/mashumaro@v3.0.4...v3.1)

---
updated-dependencies:
- dependency-name: mashumaro[msgpack]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@MichelleArk MichelleArk force-pushed the dependabot/pip/core/mashumaro-msgpack--3.1 branch from 02c98ea to 836c866 Compare November 27, 2022 22:48
@joshuataylor
Copy link
Contributor

@MichelleArk

There are a few choices for this:

  1. Bump Mashumaro to latest version and also fix the dataclass issues (There are a few changes to be made with the dataclasses - see here: https://docs.python.org/3.11/whatsnew/3.11.html#dataclasses)
  2. Leave the bump to the 3.11 upgrade Add support for Python 3.11 #6321

@MichelleArk MichelleArk requested a review from a team as a code owner November 28, 2022 16:03
@MichelleArk MichelleArk force-pushed the dependabot/pip/core/mashumaro-msgpack--3.1 branch from b677230 to 8f56fed Compare November 29, 2022 22:05
@MichelleArk MichelleArk force-pushed the dependabot/pip/core/mashumaro-msgpack--3.1 branch from 8f56fed to 7143e67 Compare November 29, 2022 22:55
@MichelleArk
Copy link
Contributor

@joshuataylor

Bumped mashumaro to the latest version (3.1.1) which includes a fix to the issue in mashumaro that was causing integration test failures in dbt-core with mashumaro 3.1. Looks like all checks are passing now 🙂

@joshuataylor
Copy link
Contributor

Whoo!! Glad it was a bug elsewhere and was an easy fix!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 30, 2022

A newer version of mashumaro[msgpack] exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@MichelleArk MichelleArk self-assigned this Nov 30, 2022
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelleArk MichelleArk merged commit b5d303f into main Nov 30, 2022
@MichelleArk MichelleArk deleted the dependabot/pip/core/mashumaro-msgpack--3.1 branch November 30, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes dependencies Changes to the version of dbt dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants