Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 failures #8256

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix flake8 failures #8256

merged 1 commit into from
Jul 31, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 31, 2023 •
edited
Loading

resolves #8255
docs dbt-labs/docs.getdbt.com/#

Problem

Sudden flake8 errors on 1.0.latest branch in automated testing.

Solution

Mark the errors to ignore since this is on the 1.0.latest branch.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jul 31, 2023
@emmyoop emmyoop requested review from nathaniel-may and a team as code owners July 31, 2023 12:16
@emmyoop emmyoop requested review from aranke and VersusFacit and removed request for a team July 31, 2023 12:16
@cla-bot cla-bot bot added the cla:yes label Jul 31, 2023
@emmyoop emmyoop changed the title Er/fix flake8 Ffix flake8 failures Jul 31, 2023
@emmyoop emmyoop changed the base branch from main to 1.0.latest July 31, 2023 12:17
@emmyoop emmyoop changed the title Ffix flake8 failures Fix flake8 failures Jul 31, 2023
@emmyoop emmyoop closed this Jul 31, 2023
@emmyoop emmyoop reopened this Jul 31, 2023
@emmyoop emmyoop requested review from jtcohen6 and removed request for nathaniel-may and VersusFacit July 31, 2023 13:38
@emmyoop emmyoop merged commit d224a82 into 1.0.latest Jul 31, 2023
21 checks passed
@emmyoop emmyoop deleted the er/fix-flake8 branch July 31, 2023 21:16
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@aranke aranke Awaiting requested review from aranke aranke was automatically assigned from dbt-labs/guild-oss-tooling

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2891] Fix flake8 errors on 1.0.latest
3 participants
@emmyoop @QMalcolm @McKnight-42