Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conflict for real not minimal snowplow tracker #8680

Closed

Conversation

akurdyukov
Copy link
Contributor

@akurdyukov akurdyukov commented Sep 20, 2023

From #8719

Closes #8719

Problem

Instaling dbt-core with meltano in the same virtualenv breaks dbt because contract conflict between minimal-snowplow-tracker (dependency of dbt) and snowplow-python-tracker.

Solution

Adds explicit version check and use minimal or full contract call.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot
Copy link

cla-bot bot commented Sep 20, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @akurdyukov

@cla-bot cla-bot bot added the cla:yes label Sep 21, 2023
@graciegoheen
Copy link
Contributor

Hey - thanks so much for opening this up! Is there is a reason you targeted the 1.4.latest branch? We typically target the main branch and backport as needed.

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Sep 26, 2023
@dbeatty10
Copy link
Contributor

Temporarily added Skip Changelog label so that we can see if this passes the CI checks (minus the check for a changelog).

This label should be removed prior to final review + merge.

@akurdyukov
Copy link
Contributor Author

Hey - thanks so much for opening this up! Is there is a reason you targeted the 1.4.latest branch? We typically target the main branch and backport as needed.

Yes, I needed get it working with dbt-clickhouse which is compatible with 1.4 only. I can open new PR to main after I fix build errors.

@akurdyukov
Copy link
Contributor Author

I'm not sure if it's correct but I fixed mypy error by ignoring.

@graciegoheen graciegoheen changed the base branch from 1.4.latest to main October 10, 2023 17:37
@graciegoheen graciegoheen requested review from a team as code owners October 10, 2023 17:37
@graciegoheen graciegoheen requested review from ashnm, Fleid and aranke and removed request for a team October 10, 2023 17:37
@graciegoheen
Copy link
Contributor

Hey @akurdyukov - I tried to re-point this PR to the main branch, but got a handful of merge conflicts. Would you be able to take a look? Thanks!

jaceksan added a commit to jaceksan/meltano that referenced this pull request Dec 5, 2023
Closes issue meltano#8256

It may be a temporary woraround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
jaceksan added a commit to jaceksan/meltano that referenced this pull request Dec 5, 2023
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
Copy link
Contributor

github-actions bot commented Jan 9, 2024

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 9, 2024
@edgarrmondragon
Copy link
Contributor

@graciegoheen do you think this PR can be salvaged or is it better to start a fresh one targeting main?

@dbeatty10 dbeatty10 changed the base branch from main to 1.4.latest January 9, 2024 02:16
@dbeatty10
Copy link
Contributor

@graciegoheen do you think this PR can be salvaged or is it better to start a fresh one targeting main?

@edgarrmondragon A fresh one targeting the main branch seems like the way to go here.

In the meantime, I switched this PR back to targeting the 1.4.latest branch to make it easier to see the original diff.

@github-actions github-actions bot removed the stale Issues that have gone stale label Jan 10, 2024
jaceksan added a commit to jaceksan/meltano that referenced this pull request Jan 30, 2024
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
jaceksan added a commit to jaceksan/meltano that referenced this pull request Jan 30, 2024
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
jaceksan added a commit to jaceksan/meltano that referenced this pull request Jan 30, 2024
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
jaceksan added a commit to jaceksan/meltano that referenced this pull request Jan 30, 2024
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
jaceksan added a commit to jaceksan/meltano that referenced this pull request Jan 30, 2024
Closes issue meltano#8256

It may be a temporary workaround -
it may be removed once dbt-labs/dbt-core#8680 is merged.
@seunggs
Copy link

seunggs commented Feb 3, 2024

Is there any progress on this @edgarrmondragon? Running into the same issue working with Meltano + dbt

@edgarrmondragon
Copy link
Contributor

Is there any progress on this @edgarrmondragon? Running into the same issue working with Meltano + dbt

@seunggs I got #9528 started

@dbeatty10
Copy link
Contributor

Thanks for doing that @edgarrmondragon 🙏

Closing this one in favor of #9528

@dbeatty10 dbeatty10 closed this Feb 6, 2024
@seunggs
Copy link

seunggs commented Feb 6, 2024

@edgarrmondragon Thank you for the update 🙏 Will track that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting_response cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
5 participants