Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include datasets with underscores when listing BigQuery datasets #954

Closed
wants to merge 1 commit into from
Closed

Include datasets with underscores when listing BigQuery datasets #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions dbt/adapters/bigquery/impl.py
View file
Open in desktop
Expand Up @@ -504,7 +504,7 @@ def get_existing_schemas(cls, profile, project_cfg, model_name=None):
client = conn.get('handle')

with cls.exception_handler(profile, 'list dataset', model_name):
all_datasets = client.list_datasets()
all_datasets = client.list_datasets(include_all=True)
return [ds.dataset_id for ds in all_datasets]

@classmethod
Expand Down Expand Up @@ -549,7 +549,7 @@ def check_schema_exists(cls, profile, project_cfg,
client = conn.get('handle')

with cls.exception_handler(profile, 'get dataset', model_name):
all_datasets = client.list_datasets()
all_datasets = client.list_datasets(include_all=True)
return any([ds.dataset_id == schema for ds in all_datasets])

@classmethod
Expand Down