Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start referring to exposures by label #307

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 20, 2022

resolves #306

Description

Refer to exposures by their label in docs.

Note: This does not behave the same as metrics without labels. This will default to use the exposure name if the exposure label is blank. Since exposures are already used widely, this prevents the docs site from going unexpectedly sideways.

Checklist

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@cla-bot cla-bot bot added the cla:yes label Sep 20, 2022
@emmyoop emmyoop requested review from stu-k and jtcohen6 and removed request for jtcohen6 September 20, 2022 20:33
@jtcohen6
Copy link
Contributor

Note: This does not behave the same as metrics without labels. This will default to use the exposure name if the exposure label is blank. Since exposures are already used widely, this prevents the docs site from going unexpectedly sideways.

Yes! Makes total sense

Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Out of curiosity, is there a reason for removing the package lock?

@emmyoop emmyoop merged commit d3bb08d into main Sep 21, 2022
@emmyoop emmyoop deleted the er/ct-1219-labels-for-exposures branch September 21, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1219] Use label instead of name for identifying exposures
3 participants