Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--owner name dave seems odd #65

Closed
b-per opened this issue Jun 14, 2023 · 1 comment · Fixed by #72
Closed

--owner name dave seems odd #65

b-per opened this issue Jun 14, 2023 · 1 comment · Fixed by #72
Assignees
@nicholasyager
Labels
enhancement New feature or request

Comments

@b-per
Copy link
Contributor

b-per commented Jun 14, 2023

Describe the feature

Adding name/email to groups has a bit of an odd syntax today: --owner name dave to assign the name dave. Is this following some CLI convention?

My initial feel is that --owner-name dave or --owner "name:dave" would seem more appropriate, but I might be wrong 😄
@b-per b-per added enhancement New feature or request triage Tis issue or pull request must be triaged by a project maintainer labels Jun 14, 2023
@nicholasyager nicholasyager self-assigned this Jun 14, 2023
@nicholasyager nicholasyager removed the triage Tis issue or pull request must be triaged by a project maintainer label Jun 14, 2023
@dave-connors-3
Copy link
Collaborator

i agree the name dave is odd

nicholasyager added a commit to nicholasyager/dbt-meshify that referenced this issue Jun 25, 2023
@nicholasyager
feat(cli): Changed CLI parameters for Ownership to be explicit
9c760c7 
I've updated how CLI arguments for owners work. Specifically, I've changed to arguments to no longer use user input to know the field name. Instad, there are new `--owner-name`, `--owner-email`, and `--owner-properties` fields. The `--owner-properties` field is used to supply a YML string that is parsed for extra properities in the object.

BREAKING CHANGE: Creates a breaking change in CLI arguments relative to current version
Resolves: dbt-labs#65
nicholasyager added a commit to nicholasyager/dbt-meshify that referenced this issue Jun 25, 2023
@nicholasyager
feat(cli): Add validation for new cli options. Move click definitions…
492d50a 
… to cli.py

Resolves: dbt-labs#65
@nicholasyager nicholasyager mentioned this issue Jun 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholasyager nicholasyager

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nicholasyager @b-per @dave-connors-3