Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi option support for select #82

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Multi option support for select #82

merged 3 commits into from
Jun 27, 2023

Conversation

dave-connors-3
Copy link
Collaborator

Closes #76

This PR uses a class from dbt to allow for MultiOption types for --select, --exclude and --selector

# before - yelled at you for too many options
dbt-meshify group us -s my_model your_model

now it works!

This code was lifted from Core directly, so I feel pretty confident that it should work!

nicholasyager
nicholasyager approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@nicholasyager nicholasyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easy!

Cpt. Picard saying "make it so"

@nicholasyager nicholasyager added the bug Something isn't working label Jun 27, 2023
@dave-connors-3 dave-connors-3 merged commit b9e55f1 into main Jun 27, 2023
1 check passed
@nicholasyager nicholasyager deleted the multi-option-support-for-select branch July 25, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasyager nicholasyager nicholasyager approved these changes

Assignees

@dave-connors-3 dave-connors-3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selector syntax does not support set operators
2 participants
@dave-connors-3 @nicholasyager