Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hard_coded_references to array #290

Closed
dave-connors-3 opened this issue Jan 26, 2023 · 3 comments
Closed

Change hard_coded_references to array #290

dave-connors-3 opened this issue Jan 26, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Stale

Comments

@dave-connors-3
Copy link
Collaborator

Describe the feature

in #265 , we had to add a Redshift shim to ensure we could fit the hard coded references into our stg models unpacking the graph. In a desire to avoid having to override type_string in the future for redshift users, one possible solution is to change this field to an array type.

checkout the branch called array-hard-coded-references for the latest attempt!

Describe alternatives you've considered

Leaving this alone!

Who will this benefit?

Redshift users who use type_string()

@dave-connors-3 dave-connors-3 added the enhancement New feature or request label Jan 26, 2023
@graciegoheen
Copy link
Collaborator

graciegoheen commented Jan 26, 2023

Note: VALUES does not support ARRAY_CONSTRUCT expression for snowflake

You may be able to do a insert into... select ... from ... values like so

insert into vartab
    select column1 as n, array_construct(column2) as v
    from values (1, 'null'), 
                (2, null), 
                (3, 'true'),
                (4, '-17'), 
                (5, '123.12'), 
                (6, '1.912e2'),
                (7, '"Om ara pa ca na dhih"  '), 
                (8, '[-1, 12, 289, 2188, false,]'), 
                (9, '{ "x" : "abc", "y" : false, "z": 10} ') 
       as vals;

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants