Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #19

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

dev #19

wants to merge 6 commits into from

Conversation

pierreberthet
Copy link

Description & motivation

To-do before merge

Screenshots:

Validation of models:

Changes to existing models:

Checklist:

  • My pull request represents one logical piece of work.
  • My commits are related to the pull request and look clean.
  • My SQL follows the dbt Labs style guide.
  • I have materialized my models appropriately.
  • I have added appropriate tests and documentation to any new models.
  • I have updated the README file.
    {%- if project.warehouse == 'redshift' %}
  • I have added sort and dist keys to models materialized as tables.
  • I have validated the SQL in any late-binding views.
    {% endif %}

@pierreberthet
Copy link
Author

fine fine

Copy link
Author

@pierreberthet pierreberthet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pierreberthet pierreberthet reopened this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant