Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1681] Replace deprecated exception functions #250

Closed
emmyoop opened this issue Dec 19, 2022 · 0 comments · Fixed by #258 or #450
Closed

[CT-1681] Replace deprecated exception functions #250

emmyoop opened this issue Dec 19, 2022 · 0 comments · Fixed by #258 or #450
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 19, 2022

dbt-core has deprecated functions to raise exceptions in favor of directly raising the exceptions. Nothing should be broken (yet) and the functions still raise as expected but they also will log a deprecation warning (pending dbt-labs/dbt-core#6413). It would be good to resolve these deprecation messages before the 1.4 rc.

There are a lot of deprecated function so it's easier to search for dbt.exceptions and look at each callsite to determine if it's using a function or already directly raising an exception. Then replace anywhere using functions with directly raising an exception.

We can create new exceptions in dbt-core to raise or the adapters could start to own their own exceptions within the adapter code base that inherit from exceptions in dbt-core.

For examples, see dbt-core PR that replaced all functions with raises.

@github-actions github-actions bot changed the title Replace deprecated exception functions [CT-1681] Replace deprecated exception functions Dec 19, 2022
@emmyoop emmyoop self-assigned this Jan 10, 2023
@emmyoop emmyoop mentioned this issue Jan 10, 2023
6 tasks
@emmyoop emmyoop mentioned this issue May 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant