Add function decorator #6413
Closed
Add function decorator #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
commented
Dec 12, 2022
| f"This will be removed in version: {self.version}." | ||
| ) | ||
| return line_wrap_message(warning_tag(f"Deprecated functionality\n\n{description}")) | ||
|
|
There was a problem hiding this comment.
This is what the text log line looks like:
17:42:33 [WARNING]: Deprecated functionality
Call to deprecated function raise_compiler_error.
Details of deprecation: Not doing it this way
To resolve this deprecation: raise CompilationException directly.
This will be removed in version 1.5.0.
There was a problem hiding this comment.
@dbeatty10 can I get your feedback on what information would be useful to get passed as an adapter maintainer? The user won't be able to do anything here but ideally the maintainer can easily fix the deprecated function.
There was a problem hiding this comment.
Sorry for my late reply here @emmyoop !
Here's a variant aiming to be succint and readable:
17:42:33 [WARNING]: `raise_compiler_error` is deprecated and will be removed in dbt-core version 1.5.0
Adapter maintainers can resolve this deprecation by using `raise CompilationException` directly instead.
Lorem ipsum dolor sit amet
Here's where each of the relevant variables would fit in:
17:42:33 [WARNING]: `{self.function_name}` is deprecated and will be removed in dbt-core version {self.version}
Adapter maintainers can resolve this deprecation by {self.suggested_action}.
{self.reason}
emmyoop
force-pushed
the
er/ct-1612-decorator
branch
from
f472f37
to
5231c2d
Compare
emmyoop
force-pushed
the
er/ct-1567-exception-cleanup
branch
from
bd34660
to
e85fb67
Compare
emmyoop
force-pushed
the
er/ct-1612-decorator
branch
from
5231c2d
to
ac59674
Compare
This was referenced Dec 19, 2022
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6393
Description
Add decorator and attach to functions to be removed from
exceptions.pyas part of #6339Checklist
changie newto create a changelog entry