Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename compiled_sql to compiled_code #145

Merged
merged 1 commit into from Jul 29, 2022
Merged

Rename compiled_sql to compiled_code #145

merged 1 commit into from Jul 29, 2022

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jul 29, 2022 •
edited

Any chance this does it? :)

Longer term:

  • convert this test
  • we probably don't even need it in dbt-redshift

@cla-bot cla-bot bot added the cla:yes label Jul 29, 2022
@leahwicz leahwicz closed this Jul 29, 2022
@leahwicz leahwicz reopened this Jul 29, 2022
@leahwicz leahwicz closed this Jul 29, 2022
@leahwicz leahwicz reopened this Jul 29, 2022
leahwicz
leahwicz approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@leahwicz leahwicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtcohen6 jtcohen6 marked this pull request as ready for review July 29, 2022 14:13
ChenyuLInx
ChenyuLInx approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leahwicz leahwicz merged commit 31b08c7 into main Jul 29, 2022
@leahwicz leahwicz deleted the jerco/fix-redshift-test-compiled-code branch July 29, 2022 16:39
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@jtcohen6
Rename compiled_sql to compiled_code (dbt-labs#145)
a5eedb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@leahwicz leahwicz leahwicz approved these changes

Assignees
No one assigned
Labels
cla:yes test all
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtcohen6 @ChenyuLInx @leahwicz