Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array macros #182

Merged
merged 11 commits into from Sep 26, 2022
Merged

Array macros #182

merged 11 commits into from Sep 26, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 13, 2022 •
edited

resolves #181
related to dbt-labs/dbt-core#5520

Description

All the related pull requests:

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Sep 13, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 13, 2022
@dbeatty10 dbeatty10 removed the Skip Changelog Skips GHA to check for changelog file label Sep 13, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@dbeatty10 dbeatty10 mentioned this pull request Sep 14, 2022
Closed
3 tasks
This was referenced Sep 21, 2022
Merged
Merged
Merged
Merged
@dbeatty10 dbeatty10 marked this pull request as ready for review September 22, 2022 01:27
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Sep 22, 2022
@dbeatty10
Copy link
Contributor Author

This is ready for review, and it depends on dbt-labs/dbt-core#5823.

After dbt-labs/dbt-core#5823 is approved and merged, I will revert the changes to dev-requirements.txt before merging this PR.

colin-rogers-dbt
colin-rogers-dbt approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbeatty10 dbeatty10 merged commit 8b9ec71 into main Sep 26, 2022
@dbeatty10 dbeatty10 deleted the dbeatty/lift-shift-array-macros branch September 26, 2022 22:49
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@dbeatty10
Array macros (dbt-labs#182)
3cd230b 
* Helper macro to cast from array to string

* Temporary dev-requirements

* Implementations and tests for array macros

* Changelog entry

* Remove unused import

* Remove `cast_array_to_string` macro

* Restore original dev-requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1157] Migrate array cross-db macros from dbt-utils
2 participants
@dbeatty10 @colin-rogers-dbt