Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dbt show tests #611

Merged
merged 8 commits into from
Sep 28, 2023
Merged

add dbt show tests #611

merged 8 commits into from
Sep 28, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 18, 2023 •
edited
Loading

resolves #616
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@MichelleArk MichelleArk mentioned this pull request Sep 18, 2023
Merged
4 tasks
MichelleArk
MichelleArk commented Sep 25, 2023
View reviewed changes
dev-requirements.txt Outdated
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-postgres&subdirectory=plugins/postgres
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@8496/limit-in-show-query#egg=dbt-postgres&subdirectory=plugins/postgres
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will undo before merging

@MichelleArk MichelleArk marked this pull request as ready for review September 25, 2023 14:03
@MichelleArk MichelleArk requested a review from a team as a code owner September 25, 2023 14:03
@MichelleArk MichelleArk mentioned this pull request Sep 28, 2023
Merged
5 tasks
@McKnight-42 McKnight-42 added backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch labels Sep 28, 2023
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) September 28, 2023 18:39
@colin-rogers-dbt colin-rogers-dbt merged commit ca3c7b4 into main Sep 28, 2023
31 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the test-limit-in-show-sql branch September 28, 2023 18:39
@McKnight-42 McKnight-42 added backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch and removed backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch labels Sep 28, 2023
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
add dbt show tests (#611)
39ef5fd 
* add dbt show tests

* changelog entry

* repoint to core main

* change to a WITH statement in model definition for dbt_show test model

* reuse core fixture for dbt show sql header test

* undo dev-requirements changes

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
(cherry picked from commit ca3c7b4)
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
add dbt show tests (#611)
8fc1eec 
* add dbt show tests

* changelog entry

* repoint to core main

* change to a WITH statement in model definition for dbt_show test model

* reuse core fixture for dbt show sql header test

* undo dev-requirements changes

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
(cherry picked from commit ca3c7b4)
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Merged
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
add dbt show tests (#611) (#620)
54bc578 
* add dbt show tests

* changelog entry

* repoint to core main

* change to a WITH statement in model definition for dbt_show test model

* reuse core fixture for dbt show sql header test

* undo dev-requirements changes

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
(cherry picked from commit ca3c7b4)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
add dbt show tests (#611) (#619)
32a1202 
* add dbt show tests

* changelog entry

* repoint to core main

* change to a WITH statement in model definition for dbt_show test model

* reuse core fixture for dbt show sql header test

* undo dev-requirements changes

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
(cherry picked from commit ca3c7b4)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@MichelleArk @colin-rogers-dbt @McKnight-42
add dbt show tests (dbt-labs#611)
dd0d983 
* add dbt show tests

* changelog entry

* repoint to core main

* change to a WITH statement in model definition for dbt_show test model

* reuse core fixture for dbt show sql header test

* undo dev-requirements changes

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Matthew McKnight <matthew.mcknight@dbtlabs.com>
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Oct 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
backport 1.5.latest Tag for PR to be backported to the 1.5.latest branch backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-917] [Tests] Add tests for inlined limit + sql_header in dbt show query
3 participants
@MichelleArk @McKnight-42 @colin-rogers-dbt