Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redshift internal build process workflow #732

Merged
merged 25 commits into from
Mar 19, 2024

Conversation

VersusFacit
Copy link
Contributor

resolves #38 in epic

Problem

We need a workflow to release things internally

Solution

Write the workflow. I'll be opening up a PR for the workflow this one calls.

Followup actions including reconfiguring secrets and doing a full run start to finish!

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Mar 18, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 18, 2024
setup.py Show resolved Hide resolved
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - mostly some questions/changes for the inputs.

.changes/unreleased/Features-20240318-030018.yaml Outdated Show resolved Hide resolved
.github/workflows/release-internal.yml Show resolved Hide resolved
.github/workflows/release-internal.yml Show resolved Hide resolved
.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
.github/workflows/release-internal.yml Show resolved Hide resolved
.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
invoke-reusable-workflow:
name: Build and Release Internally

uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this needs to be updated once the dbt-release PR gets merged.

Suggested change
uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
uses: dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@main

.github/workflows/release-internal.yml Outdated Show resolved Hide resolved
@@ -50,7 +61,7 @@ def _plugin_version() -> str:
install_requires=[
"dbt-common>=0.1.0a1,<2.0",
"dbt-adapters>=0.1.0a1,<2.0",
f"dbt-postgres~={_plugin_version()}",
f"dbt-postgres~={_plugin_version_trim()}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikealfare can this be done without ~=?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would need to look at it, but I would think so. We would need to update the function to return a tuple, something along the lines of "dbt-postgres>={},<{}".format(_plugin_version()) where _plugin_version() == (1.8.0b1, 1.9).

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is for now with the understanding that more PRs will follow on after testing since none of this can be tested before the workflow gets merged. Since this is a workflow that will be manually submitted there is little risk in this approach.

@mikealfare
Copy link
Contributor

Tests are failing here due to the ddtrace break. This is an unrelated issue. The primary motivation of merging this PR is to get a workflow in main that can be tested in a future PR. This PR represents partial, and on-going work.

@mikealfare mikealfare merged commit 1e217f8 into dbt-labs:main Mar 19, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants