New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sqlparse to be in line with dbt-core #768

Merged

colin-rogers-dbt merged 7 commits into main from mcknight/sqlparse-update

Apr 18, 2024

Contributor

McKnight-42 commented Apr 17, 2024 •

edited

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

we pinned sqlparse to not go out of range of dbt-core and they recently upgraded we are raising pin to stay in line

similar issue seen in dbt-postgres when migrating tests from that repo back to adapters/core dbt-labs/dbt-core#9951

Solution

Checklist

I have read the contributing guide and understand what's expected of me
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX


          update sqlparse requirement to be in parity with dbt-core

bbe438a

McKnight-42 requested a review from mikealfare

April 17, 2024 00:51

McKnight-42 self-assigned this

cla-bot bot added the cla:yes label

Contributor

github-actions bot commented Apr 17, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

McKnight-42 added 2 commits

April 16, 2024 19:59


          add changelog


          allow verify tests to pass (will need to patch)

cff7161

mikealfare approved these changes

View reviewed changes

zwallacedev commented Apr 17, 2024

Anything we can do to prioritize this merge?

McKnight-42 added 4 commits

April 17, 2024 14:51


          pin core, update changelong, add ref to core security issue

cbef11a


          revert core pin as not in pypi

ab57ec4


          update changelong to match core, reapply core new bound

3be924e


          pushing bound back up to be in line of what new core will be after b3…

faa82ac

… release

emmyoop mentioned this pull request

unpin sqlparse to avoid version conflicts #769

Closed

4 tasks

colin-rogers-dbt closed this

colin-rogers-dbt reopened this

colin-rogers-dbt enabled auto-merge (squash)

April 18, 2024 18:25

colin-rogers-dbt disabled auto-merge

April 18, 2024 18:55

colin-rogers-dbt merged commit 663b8ed into main

36 of 54 checks passed

colin-rogers-dbt deleted the mcknight/sqlparse-update branch

April 18, 2024 18:55

colin-rogers-dbt added backport 1.6.latest backport 1.7.latest labels

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-768-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-768-to-1.7.latest.

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-768-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-768-to-1.6.latest.

McKnight-42 added backport 1.6.latest backport 1.7.latest and removed backport 1.6.latest backport 1.7.latest labels

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-768-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-768-to-1.6.latest.

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-768-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-768-to-1.7.latest.

McKnight-42 added backport 1.6.latest and removed backport 1.6.latest backport 1.7.latest labels

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-768-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-768-to-1.6.latest.

colin-rogers-dbt added the backport 1.7.latest label

Contributor

github-actions bot commented Apr 18, 2024

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-768-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 663b8edfb1d1f36e5014e9a2e9455dc771bdb722
# Push it to GitHub
git push --set-upstream origin backport-768-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-768-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment