remove unneeded dbt-core installs in action as test run based off tox… #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… install of dev_requirements
kwigley
approved these changes
Mar 25, 2022
Comment on lines
-165
to
-171
| - name: Install dbt-core from branch ${{ steps.dbt-core-version.outputs.dbt-core-ref }} | ||
| run: | | ||
| pip install "git+https://github.com/dbt-labs/dbt-core.git@${{ steps.dbt-core-version.outputs.dbt-core-ref }}#egg=dbt-core&subdirectory=core" | ||
|
|
||
| - name: Install dbt-postgres from ${{ steps.dbt-core-version.outputs.dbt-core-ref }} | ||
| run: | | ||
| pip install "git+https://github.com/dbt-labs/dbt-core.git@${{ steps.dbt-core-version.outputs.dbt-core-ref }}#egg=dbt-postgres&subdirectory=plugins/postgres" |
There was a problem hiding this comment.
These were unnecessary because we use tox to run tests. tox creates a virtualenv and installs dependencies from dev_requirement.txt when running tests
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
dbt-labs#90) * remove unneeded dbt-core installs in action as test run based off tox install of dev_requirements * add changelog and removed redundant entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # 80
Description
Removes unused installs of dbt-core outside of tox env as it clutters up gha and can lead to misunderstanding of which version of dbt-core is being installed.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-redshift next" section.