Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-945] Support updating raw_sql to raw_code and compiled_sql to compiled_code #89

Closed
ChenyuLInx opened this issue Jul 27, 2022 · 0 comments · Fixed by #90
Closed

[CT-945] Support updating raw_sql to raw_code and compiled_sql to compiled_code #89

ChenyuLInx opened this issue Jul 27, 2022 · 0 comments · Fixed by #90
Assignees

Comments

@ChenyuLInx
Copy link
Contributor

We updated the attribute name in dbt-core given SQL is no longer the only language dbt support.
But given the fact that we want to depreciate dbt-rpc by the end of the year, we think it is best to convert the attribute name back to what it used to be to make this transition smoother for existing rpc server user.

In order to do it, dbt-rpc would:

  • be able to pull results from both new name(raw_code, compiled_cdoe) and the old name(raw_sql, compiled_sql) from dbt-core
  • return results in API call will still use the old name(raw_sql, compiled_sql).
  • for manifest.json, we just return the current manifest, there's no modification of it. Meaning that new names are going to be used there
@github-actions github-actions bot changed the title Support updating raw_sql to raw_code and compiled_sql to compiled_code [CT-945] Support updating raw_sql to raw_code and compiled_sql to compiled_code Jul 27, 2022
@ChenyuLInx ChenyuLInx mentioned this issue Jul 27, 2022
2 tasks
@ChenyuLInx ChenyuLInx self-assigned this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant