Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding measure protocol #35

Merged
merged 4 commits into from
May 15, 2023
Merged

Adding measure protocol #35

merged 4 commits into from
May 15, 2023

Conversation

callum-mcdata
Copy link
Contributor

@callum-mcdata callum-mcdata commented May 15, 2023 •
edited
Loading

resolves #14

Description

First cut of the measures protocol. VERY UNSURE ON PROPERTIES IN MIXIN CLASS.

Checklist

@cla-bot cla-bot bot added the cla:yes label May 15, 2023
@dbt-labs dbt-labs deleted a comment from github-actions bot May 15, 2023
QMalcolm
QMalcolm approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo! The train is a rolling 🚂

@callum-mcdata callum-mcdata merged commit cea6b92 into main May 15, 2023
6 checks passed
This was referenced May 16, 2023
Closed
Merged
@callum-mcdata callum-mcdata deleted the adding-measure-protocol branch May 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

Assignees
No one assigned
Labels
cla:yes review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create protocol abstraction for Measures
2 participants
@callum-mcdata @QMalcolm