Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1091] [Feature] Include Snowflake session_id in run results response #881

Closed
3 tasks done
akaul opened this issue Jan 9, 2024 · 3 comments · May be fixed by #904
Closed
3 tasks done

[ADAP-1091] [Feature] Include Snowflake session_id in run results response #881

akaul opened this issue Jan 9, 2024 · 3 comments · May be fixed by #904
Labels
enhancement New feature or request Stale triage

Comments

@akaul
Copy link

akaul commented Jan 9, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

As a dbt user, I want to be able to quickly look up information about the set of queries associated with a dbt model run rather than just the final create/insert/update statement. While the query_id is powerful, the session_id can provided richer information back to Snowflake users to under the full lifecycle of queries executed.

To implement this feature, we could extend the SnowflakeAdapterResponse to include the session_id.

@dataclass
class SnowflakeAdapterResponse(AdapterResponse):
    query_id: str = ""
    session_id: str = ""

Describe alternatives you've considered

Similar to the alternatives discussed within #7, a post-hook might work, but not give an idea of the full lifecycle in case of failures.

Who will this benefit?

This would help dbt-snowflake users to more effectively debug and understand why their queries succeeded or failed.

Are you interested in contributing this feature?

Yes!

Anything else?

No response

@akaul akaul added enhancement New feature or request triage labels Jan 9, 2024
@github-actions github-actions bot changed the title [Feature] Include Snowflake session_id in run results response [ADAP-1091] [Feature] Include Snowflake session_id in run results response Jan 9, 2024
@instazackwu
Copy link

+1, being able to easily see all connected queries in a given model instead of just the final query would be be very helpful in debugging / potential optimization!

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 8, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants