Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowflake session id to run result #904

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jeppe742
Copy link

@jeppe742 jeppe742 commented Feb 15, 2024

resolves #881

Problem

As described in #881, it would be very useful to get the session_id from the RunResult.
This especially makes sense for incremental models, where the model is split into multiple queries, of which only the last is returned by query_id, but all have the same session_id

Solution

Similar to #109, we will just add a property to SnowflakeAdapterResonse and fetch the session_id from the Snowflake connection

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@jeppe742 jeppe742 requested a review from a team as a code owner February 15, 2024 14:24
@cla-bot cla-bot bot added the cla:yes label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-1091] [Feature] Include Snowflake session_id in run results response
1 participant