Add refresh_mode and initialize as dynamic table options
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic-table-parameters
4 tasks
jtcohen6
reviewed
Jun 14, 2024
dbt/include/snowflake/macros/relations/dynamic_table/replace.sql
Outdated
Show resolved
Hide resolved
mikealfare
changed the title
refresh_mode, initialize, and comment as dynamic table optionsrefresh_mode and initialize as dynamic table options
3 tasks
mikealfare
commented
Jun 17, 2024
| @@ -1,8 +1,16 @@ | |||
| {% macro snowflake__get_create_dynamic_table_as_sql(relation, sql) -%} | |||
|
|
|||
| {%- set dynamic_table = relation.from_config(config.model) -%} | |||
There was a problem hiding this comment.
Using the RelationConfig allows us to easily incorporate input validation for refresh_mode and initialize. If we're doing that, we should pull all attribution from this class, hence updating target_lag and snowflake_warehouse.
mikealfare
commented
Jun 17, 2024
| {% macro snowflake__get_replace_dynamic_table_sql(relation, sql) %} | ||
| {% macro snowflake__get_replace_dynamic_table_sql(relation, sql) -%} | ||
|
|
||
| {%- set dynamic_table = relation.from_config(config.model) -%} |
There was a problem hiding this comment.
Same comment as for snowflake__get_create_dyanmic_table_sql.
mikealfare
commented
Jun 17, 2024
| as ( | ||
| {{ sql }} | ||
| ) | ||
| ; | ||
| {{ snowflake__refresh_dynamic_table(relation) }} |
There was a problem hiding this comment.
This is now handled via the initialize parameter. Since initialize defaults to ON_CREATE, this is consistent with the current behavior.
colin-rogers-dbt
approved these changes
Jun 18, 2024
|
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5678 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #868
This PR continues @HenkvanDyk's work in #893.
Note
We are not adding
commmenthere since that is already managed via the standard configdescription. We'll make sure that the docs reflect this.Checklist