-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set/unset_query_tag to the dbt macro namespace #132
add set/unset_query_tag to the dbt macro namespace #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robscriva Looking good! One comment from me. Otherwise, this will be good to ship in v1.2.
Not sure what's going on with those test failures, will need to take a more detailed look |
Just a coincidence after I swapped to use the |
@robscriva Definitely a coincidence. We're seeing those tests fail in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robscriva Looks great, thank you!
I just added a contributor entry. We can merge as soon as the tests pass.
resolves #133
Description
There is no way of overriding the
set_query_tag
andunset_query_tag
macros to create a custom query tag within an external package. This is because these macros aren't part of the dbt namespace and therefore cannot be overridden with dispatching precedence in the project. This change adds both macros to the dbt macro namespace so they can be overridden externally.Discussion here: https://getdbt.slack.com/archives/C37J8BQEL/p1633519489312300?thread_ts=1633377998.228400&cid=C37J8BQEL
Checklist
CHANGELOG.md
and added information about my change to the "dbt-snowflake next" section.