Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redudant pip install commands for workflow. #145

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

VersusFacit
Copy link
Contributor

Description

Surfaced by Chenyu in review of dbt-redshift PR 105. These are already found in the dev_requirements.txt and don't need explicit inclusion like so

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

Surfaced by Chenyu in review of dbt-redshift PR 105. These are already found in the dev_requirements.txt and don't need explicit inclusion like so
@VersusFacit VersusFacit self-assigned this Apr 25, 2022
@cla-bot cla-bot bot added the cla:yes label Apr 25, 2022
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VersusFacit VersusFacit merged commit ae31719 into main Apr 25, 2022
@VersusFacit VersusFacit deleted the cleanup_precommit_workflow branch April 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants