Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ct 1529/python 3 11 support #354

Merged
merged 25 commits into from
Mar 9, 2023
Merged

Ct 1529/python 3 11 support #354

merged 25 commits into from
Mar 9, 2023

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 13, 2022 •
edited

resolves #331

Description

Python 3.11 was added as a supported version of python in several configurations throughout the code base.

Checklist

@cla-bot cla-bot bot added the cla:yes label Dec 13, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare self-assigned this Dec 14, 2022
@joshuataylor
Copy link
Contributor

joshuataylor commented Dec 27, 2022 •
edited

You might want to pull in #336, maybe as a commit? Then we can close the other one.

That PR has been tested and verified with Python 3.11 and snowflake-connector-python with the noted PR.

@mikealfare
Copy link
Contributor Author

Agreed, #336 resolves the issue for py3.11. Thanks for the research there. However, it doesn't seem to work for py3.7-3.10. I'll look at how to combine the two so that the correct requirements are pulled for each version of python.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review January 30, 2023 19:10
@dbeatty10
Copy link
Contributor

You might want to pull in #336, maybe as a commit? Then we can close the other one.

That PR has been tested and verified with Python 3.11 and snowflake-connector-python with the noted PR.

@joshuataylor doing some quick research, it looks like we pulled the following into #350

Thank you so much for your help getting Python 3.11 working. I've added you as a contributor to the changelog entry on this PR.

VersusFacit
VersusFacit approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my own searches for anywhere we'd need to add 3.11 throughout the repo, this looks good to me. Glad to see the tests passing on all version.

@Fleid Fleid added the tech_debt label Feb 1, 2023
@mikealfare mikealfare marked this pull request as draft February 16, 2023 16:15
mikealfare and others added 9 commits February 16, 2023 22:45
@mikealfare mikealfare marked this pull request as ready for review March 8, 2023 19:02
@mikealfare mikealfare requested a review from a team as a code owner March 8, 2023 19:02
@mikealfare mikealfare added the backport 1.4.latest Tag for PR to be backported to the 1.4.latest branch label Mar 8, 2023
@mikealfare mikealfare merged commit 5f4fbe0 into main Mar 9, 2023
@mikealfare mikealfare deleted the ct-1529/python-3_11-support branch March 9, 2023 00:47
mikealfare added a commit that referenced this pull request Mar 9, 2023
@mikealfare @dataders @dbeatty10
Ct 1529/python 3 11 support (#354)
d0c96e1 
* add python 3.11 as run options for testing (and eventually publishing)
* Changelog entry

---------

Co-authored-by: Anders <anders.swanson@dbtlabs.com>
Co-authored-by: Doug Beatty <doug.beatty@dbtlabs.com>
mikealfare added a commit that referenced this pull request Mar 9, 2023
@mikealfare @dataders @dbeatty10
Ct 1529/python 3 11 support (#354) (#510)
3ee3b1e 
* add python 3.11 as run options for testing (and eventually publishing)
* Changelog entry

---------

Co-authored-by: Anders <anders.swanson@dbtlabs.com>
Co-authored-by: Doug Beatty <doug.beatty@dbtlabs.com>
@dbeatty10 dbeatty10 mentioned this pull request May 4, 2023
Merged
1 task
dbeatty10 added a commit to dbt-labs/docs.getdbt.com that referenced this pull request May 5, 2023
@dbeatty10 @mirnawong1
dbt-snowflake supports Python 3.11 now (#3337)
2d4c941 
## What are you changing in this pull request and why?
[Slack
thread](https://dbt-labs.slack.com/archives/C0131TY7EEA/p1683202545191779)

dbt-labs/dbt-snowflake#354

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.

Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

@McKnight-42 McKnight-42 Awaiting requested review from McKnight-42

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

Assignees

@mikealfare mikealfare

Labels
backport 1.4.latest Tag for PR to be backported to the 1.4.latest branch cla:yes tech_debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1529] [Feature] Support Python 3.11
6 participants
@mikealfare @joshuataylor @dbeatty10 @VersusFacit @dataders @Fleid