Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for pytest-dbt-adapter #314

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 31, 2022

resolves #313

Description

We are moving away from using pytest-dbt-adapter, in favor of the new testing framework. Remove requirement and switch spark session to use new tests.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 31, 2022
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChenyuLInx ChenyuLInx merged commit d92a4e5 into main Mar 31, 2022
@ChenyuLInx ChenyuLInx deleted the ct-447-remove_pytest-dbt-adapter_requirement branch March 31, 2022 21:39
ueshin added a commit to databricks/dbt-databricks that referenced this pull request Apr 1, 2022
### Description

Port testing framework changes from dbt-labs/dbt-spark#299 and dbt-labs/dbt-spark#314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-447] Remove requirement for pytest-dbt-adapter
2 participants