Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing whitespace in group_by #174

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

ltchikindas
Copy link
Contributor

reducing whitespace in compiled SQL for legibility

select
foo.a
, foo.b
, foo.c
, sum(foo.d)
from
foo
{{group_by(n=3)}}

now results in

select
foo.a
, foo.b
, foo.c
, sum(foo.d)
from
foo
group by
1,2,3

reducing whitespace in compiled SQL for legibility
@drewbanin
Copy link
Contributor

drewbanin commented Nov 17, 2019

Thanks @ltchikindas! This one was a long time coming :)

Just kicked off a build here - one minor nit commented inline, then this will be good to merge when the tests pass :)

macros/sql/groupby.sql Show resolved Hide resolved
now remove line break after `group by`
@clrcrl clrcrl self-requested a review December 4, 2019 17:04
Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@clrcrl clrcrl merged commit 30ef9f1 into dbt-labs:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants