Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce whitespace in dbt_utils.star #176

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

mjumbewu
Copy link
Contributor

A call to {{ dbt_utils.star(this, relation_alias='x') }} previously would produce something like:

      

         x. 
  "column1"
 ,
        

         x. 
  "column2"
 ,
        

         x. 
  "column3"

Now produces:

x."column1",
x."column2",
x."column3"

The latter plays more nicely with the readability of the compiled sql. No leading or trailing whitespace, and just a newline between each column reference.

Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!

@clrcrl clrcrl merged commit 9a155f2 into dbt-labs:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants