Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about dbt-duckdb adapter #1610

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Add documentation about dbt-duckdb adapter #1610

merged 3 commits into from
Jun 21, 2022

Conversation

TylerHillery
Copy link
Contributor

Description & motivation

Related to issue #1489

Prerelease docs

Is this change related to an unreleased version of dbt?

  • No: please ensure the base branch is current

Checklist

If you added new pages (delete if not applicable):

  • The page has been added to website/sidebars.js
  • The new page has a unique filename

@netlify
Copy link

netlify bot commented Jun 18, 2022

Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f13db4
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/62ae62cf15667e000895190a
😎 Deploy Preview https://deploy-preview-1610--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Jun 18, 2022
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerHillery very much appreciate your contribution here -- especially the written explanation of what connection configurations exist.

My first thought was to ask you to make a duckdb-config.md page, but looking at duckdb's CREATE TABLE docs, it doesn't seem there are no special configuration considerations for tables and view materializations.

Here's my underinformed brain thumb of things that might require docs:

  • database-wide configuration options e.g. threads? might that correspond to the number of threads that dbt might want to use?
  • VIRTUAL and STORED columns (though IIUC, STORED isn't possible yet?
  • the "dbtonic" way of "importing" from file formats like parquet. is it via dbt-external-tables? Or is best practice that a dbt user should make the models at the top of the tag use the FROM filename.parquet instead of the {{ source(filename) }} convention?
    cc: @jwills aka the Willy Wonka of Data

@TylerHillery
Copy link
Contributor Author

TylerHillery commented Jun 21, 2022

@dataders I appreciate the feedback. I will do some more research on these topics to see what I can do for a duckdb-config.md file.

@dataders
Copy link
Contributor

@dataders I appreciate the feedback. I will do some more research on these topics to see what I can do for a duckdb-config.md file.

sweet! in the meantime I'll merge this PR, and you can open another when you're ready to add more config info. Generally, my stoke level is high for both duck db and dbt-duckdbt so I'm happy to support where able.

@dataders dataders merged commit e776198 into dbt-labs:current Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants