Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting as_text page #4726

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Deleting as_text page #4726

merged 9 commits into from
Jan 10, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Jan 9, 2024

What are you changing in this pull request and why?

The filter function referenced on this page hasn't done anything since dbt Core v0.17.0.

As this version is wildly outdated, we are deleting the page

Nothing to delete from sidebar.js as this is autogenerated

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner January 9, 2024 18:56
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:57pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Jan 9, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver just some tiny suggestions.

matthewshaver and others added 4 commits January 10, 2024 10:58
…upgrading-to-0-17-0.md

Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
…upgrading-to-0-17-0.md

Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewshaver matthewshaver merged commit 611822e into current Jan 10, 2024
7 checks passed
@matthewshaver matthewshaver deleted the as-text-delete branch January 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs January-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants