-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incremental-models.md #5306
Conversation
If event_time is NULL or the table is truncated, the condition will always be true and load all records. This is an edge case. If an final table is truncated. dbt condisider it as incremental load. then the model will fail, to avoid that situation.
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @zvijayakumar, thanks for opening this up and great addition for this edge case! i like the addition of preventing errors if the SQL engine interprets the string differently or fails to convert it properly. will get this merged for you!
i would recommend (if you haven't already) searching for or adding an issue in the dbt core repo to flag the edge case safeguarding. thanks again and looking forward to you future contributions !
If event_time is NULL or the table is truncated, the condition will always be true and load all records. This is an edge case.
If a final table is truncated it will return the NULL as the result
( select * from table where event_time > NULL ) --> return no results
It will not have any data in it and dbt considers it as incremental load. then the model will fail, to avoid that situation. In dbt we don't have anything to handle this situation.
What are you changing in this pull request and why?
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/vercel.json
npm run build
to update the links that point to deleted pages