This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Add .venv and npm to container build #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per idea from Evidence this PR add npm install to the container build, it also, although unnecessary in a container, adds a virtual environment so that settings are correct and consistent between local and dev container development. Closes #10 #11
It also move dbt Power User to a recommended rather than automatically installed extension, since it seems to have issues with order of operations and throws error about dbt not being installed, the python extension not being installed, etc. We can troubleshoot those at some point but for now I'd rather not have known errors on build for this. Closes #12