-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
@aaronsteers running into some issues with either port forwarding or something else going on with this branch in Codespaces. i'm going to loop back around tomorrow morning with a fresher brain. but in general i dig what's happening here, and once i can confirm it's working for Codespaces will get it in. 🙏🏻 |
@gwenwindflower - No rush at all. I actually ran into problems with the port not being accessible when using Codespaces also, then switched to local development for that reason. Sorry for not raising it in the PR description - I made the switch early on and then forgot to loop back and retest. I wonder if this is a break related to v14, perhaps related to the Svelte version bump. Perhaps someone else ran into something similar and opened an issue on the Evidence side. Probably worth holding off on merging this PR until the port issue is resolved. I am considering if it's worth reverting the version bump on my other PRs, but the DuckDB file versions are not compatible. So downgrading Evidence would cascade into me also needing to downgrade DuckDB in other places as well. 😬🤦♂️ |
We're working through our v14 issues now! Hoping to have some fixes soon I like the changes to the Evidence readme. One other thing we can do to remove a step in the process is add the "postCreateCommand": "python -m pip install --user -r requirements.txt && dbt deps && npm --prefix ./reports install", With that, we can get the startup commands down to: cd reports
npm run dev |
@gwenwindflower - Issue evidence-dev/evidence#690 resolved and the updated 👍 Also, I updated this branch with the latest from main and cleaned up some of the excess file changes in the diff. To my knowledge, my only last concern is evidence-dev/evidence#682 (build:strict command). |
@aaronsteers ayyyy awesome! |
* install meltano feature in codespace * `meltano init` * feat: define meltano plugins, jobs, environments * chore: limit to 1 year for faster dev builds * chore: simplify config * docs: how to invoke with meltano * bump evidence version, update readme * dynamic schema and db names * chore: fix tabs v spaces * feat: working bi dev environment via `meltano invoke evidence:dev` * chore: bump dbt versions * docs: fix evidence header * ci: add e2e ci test * chore: drop extra package.json file * feat: prefer extracted datasets includes code comment with instructions on how to use seed files * feat: meltano 'full-build' job * chore: add env var JAFFLE_RAW_SCHEMA * fix: profile cannot access dbt vars (fixed conflicts) * chore: workaround var issue * fix: sources don't parse vars * fix: missing 'run' in CI cli call * run on push * ci: add missing 'meltano install' * ci: remove extra check, improve output readability * ci: use dbt:build * ci: fix plugin name * chore: bump tap-jaffle-shop version * fix: evidence duckdb filename * fix: add explicit datetime casts * ci: add step descriptions * chore: revert extra datetime casts * chore: Bump evidence to v14 (#3) * feat: dynamic raw data * fix: remove extra dbt var * docs: delete dupe section * fix: use env var for schema name * ci: add github pages publish (#5) * hotfix: relative path for gh pages * ci: upload duckdb file artifact (#7) * Use `meltano install` in Codespaces setup (#8) * Chore: move project-id to client-id (#9) * Bump-evidence-to-v15 (#10) * chore: delete lock files * chore: simplify devcontainer * chore: remove comment * chore: remove non-EL utilities and jobs * chore: tidy up comments * chore: revert and simplify ci pipeline * docs: improve readme for the EL use case * Update reports/pages/index.md * chore: remove extra gitignore line * ci: streamline install * chore: further simplify meltano.yml * ci: add pip caching to speed up builds * ci: keep isolated venvs * fix: relative path to db * chore: simplify header comment * chore: simplify raw sources.yml, get data from extracts * fix: explicit load schema * chore: human-readable project id * codespaces: add `meltano run el` to post-create script * chore: bump tap-jaffle-shop (soon-to-be released) * chore: dummy commit to force ci build * revert: dummy change --------- Co-authored-by: winnie <91998347+gwenwindflower@users.noreply.github.com>
Note:
There's a known issue with Evidence 14.0 related to build-strict not working:
Codespace testing URL: https://github.com/codespaces/new?hide_repo_select=true&ref=bump-evidence-to-v14&repo=612676159