Skip to content

Commit

Permalink
Update snapshots to reflect the optimizer fix for duplicate metrics.
Browse files Browse the repository at this point in the history
  • Loading branch information
@plypaul
plypaul committed Dec 18, 2023
1 parent c482a2e commit 85d68e3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 23 deletions.
7 changes: 0 additions & 7 deletions ...rce_scan_optimizer.py/DataflowPlan/test_2_ratio_metrics_from_1_semantic_model__dfpo_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'booking_value', -->
Expand Down
12 changes: 6 additions & 6 deletions ...t/snapshots/test_source_scan_optimizer.py/DataflowPlan/test_duplicate_measures__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'derived_bookings_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -21,7 +21,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down Expand Up @@ -53,7 +53,7 @@
<ReadSqlSourceNode>
<!-- description = -->
<!-- Read From SemanticModelDataSet(SemanticModelReference(semantic_model_name='bookings_source')) -->
<!-- node_id = rss_10011 -->
<!-- node_id = rss_10013 -->
<!-- data_set = -->
<!-- SemanticModelDataSet(SemanticModelReference(semantic_model_name='bookings_source')) -->
</ReadSqlSourceNode>
Expand All @@ -68,7 +68,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'derived_bookings_1', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -78,7 +78,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down Expand Up @@ -110,7 +110,7 @@
<ReadSqlSourceNode>
<!-- description = -->
<!-- Read From SemanticModelDataSet(SemanticModelReference(semantic_model_name='bookings_source')) -->
<!-- node_id = rss_10011 -->
<!-- node_id = rss_10013 -->
<!-- data_set = -->
<!-- SemanticModelDataSet(SemanticModelReference(semantic_model_name='bookings_source')) -->
</ReadSqlSourceNode>
Expand Down
13 changes: 3 additions & 10 deletions .../snapshots/test_source_scan_optimizer.py/DataflowPlan/test_duplicate_measures__dfpo_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'derived_bookings_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'derived_bookings_1', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -25,14 +25,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down

0 comments on commit 85d68e3

Please sign in to comment.