Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-1720] [Feature] Remove SQL-Comment-Based Tags #1034

Closed
3 tasks done
plypaul opened this issue Feb 15, 2024 · 0 comments · Fixed by #1036 or #1026
Closed
3 tasks done

[SL-1720] [Feature] Remove SQL-Comment-Based Tags #1034

plypaul opened this issue Feb 15, 2024 · 0 comments · Fixed by #1036 or #1026
Assignees
@plypaul
Labels
enhancement New feature or request High priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@plypaul
Copy link
Contributor

plypaul commented Feb 15, 2024 •
edited

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

There was a previous mechanism to add SQL comments that encode various tags in generated SQL. Since this is no longer needed due to SQL client / adapter changes, those generated comments can be removed.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

SL-1720
@plypaul plypaul added enhancement New feature or request triage Tasks that need to be triaged labels Feb 15, 2024
@plypaul plypaul self-assigned this Feb 15, 2024
@plypaul plypaul changed the title [Feature] Remove SQL-Comment-Based Tags [SL-1720] [Feature] Remove SQL-Comment-Based Tags Feb 15, 2024
plypaul added a commit that referenced this issue Feb 15, 2024
@plypaul
Add change loog for #1034.
e81d3b4
plypaul added a commit that referenced this issue Feb 15, 2024
@plypaul
Add change log for #1034.
f7a3f03
@plypaul plypaul mentioned this issue Feb 15, 2024
Merged
@plypaul plypaul added High priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync labels Feb 15, 2024
@plypaul plypaul closed this as completed Feb 22, 2024
plypaul added a commit that referenced this issue Feb 28, 2024
@plypaul
Add change log for #1034.
24cca70
@tlento tlento linked a pull request Mar 2, 2024 that will close this issue
Remove Tag-Related Comments in Generated SQL #1026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plypaul plypaul

Labels
enhancement New feature or request High priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Milestone
No milestone
1 participant
@plypaul