Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-1450] [Bug] Optimizer Does Not Deduplicate Common Metrics #941

Closed
2 tasks done
plypaul opened this issue Dec 15, 2023 · 0 comments
Closed
2 tasks done

[SL-1450] [Bug] Optimizer Does Not Deduplicate Common Metrics #941

plypaul opened this issue Dec 15, 2023 · 0 comments
Assignees
Labels
bug Something isn't working High priority Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@plypaul
Copy link
Contributor

plypaul commented Dec 15, 2023

Is this a new bug in metricflow?

  • I believe this is a new bug in metricflow
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

If a query includes multiple derived metrics that use a common metric, the optimizer currently does not deduplicate those metrics when combining metric computation branches. If those metrics are not deduplicated, then the resulting SQL will have a column alias error. See: f4691d7#diff-6beb9d2e40a8992c43163d08246fc08088cef8b29bdc6c3ff17b6c173f0f7514R22

Expected Behavior

Common metrics should be deduplicated. See 9fa4aaf#diff-6beb9d2e40a8992c43163d08246fc08088cef8b29bdc6c3ff17b6c173f0f7514L32

Steps To Reproduce

See: f4691d7

Relevant log output

No response

Environment

- metricflow: 0.204.0.dev2

Which database are you using?

No response

Additional Context

No response

From SyncLinear.com | SL-1450

@plypaul plypaul added bug Something isn't working triage Tasks that need to be triaged labels Dec 15, 2023
@plypaul plypaul changed the title [Bug] Optimizer Does Not Deduplicate Common Metrics [SL-1450] [Bug] Optimizer Does Not Deduplicate Common Metrics Dec 15, 2023
plypaul added a commit that referenced this issue Dec 15, 2023
plypaul added a commit that referenced this issue Dec 15, 2023
@plypaul plypaul added the Metricflow Created by Linear-GitHub Sync label Dec 18, 2023
@plypaul plypaul self-assigned this Dec 18, 2023
@plypaul plypaul added High priority Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Dec 18, 2023
plypaul added a commit that referenced this issue Dec 18, 2023
plypaul added a commit that referenced this issue Dec 18, 2023
@plypaul plypaul closed this as completed Jan 4, 2024
@plypaul plypaul removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High priority Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant