Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the Package #57

Merged
merged 5 commits into from
May 21, 2019
Merged

Cleaning up the Package #57

merged 5 commits into from
May 21, 2019

Conversation

emilieschario
Copy link
Contributor

Issue

Closes #25, #47, and #48

Solution

This PR:

  • deletes the no-longer-used lookml file
  • adds the PK to the page views model (based on where the unique test on the model is)
  • adds the additional filter for bot traffic

@emilieschario emilieschario marked this pull request as ready for review May 4, 2019 11:25
@emilieschario
Copy link
Contributor Author

@jtcohen6 @eogilvy12 These are super small changes closing some issues I noticed. This is ready for review. 👍

@jtcohen6
Copy link
Contributor

jtcohen6 commented May 5, 2019

@emilieschario I checked out these changes locally, and it looks like all of our integration tests are passing. (They don't seem to be triggered on PRs opened from forks?)

I think this PR nicely rounds out a new release, which would include my recent tweaks in #51 and #53

@emilieschario
Copy link
Contributor Author

@jtcohen6 Sounds great to me 👍

@jtcohen6 jtcohen6 added this to the 0.7.3 milestone May 16, 2019
Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! Approved and merging :)

@drewbanin drewbanin merged commit 2478b8d into dbt-labs:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional bot traffic
3 participants