fix: adds pyodbc output converter for DATETIMEOFFSET data types #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldwicc
changed the title
baldwicc
force-pushed
the
datetimeoffset-patch
branch
from
f3cb585
to
3e7ef16
Compare
sdebruyn
force-pushed
the
datetimeoffset-patch
branch
from
3e7ef16
to
d620ee7
Compare
|
@baldwicc Thank you! Sorry for the long wait, merging this today |
for more information, see https://pre-commit.ci
sdebruyn
force-pushed
the
datetimeoffset-patch
branch
from
6b216ca
to
4307e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253, supercedes #254
pyodbc is unlikley to include a handler for DATETIMEOFFSET data types - see mkleehammer/pyodbc#134.
So, this PR adds support to convert these datatypes to standard
datetimeobjects based on public MS documentation.This should allow freshness functonality to use DATETIMEOFFSET columns without needing to use CAST/CONVERT in loaded_at_field resource properties.
Tests are against
str(value: datetime)default string format, since this asserts compatibility with: