Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim dbt-expectations macros #47

Merged
merged 18 commits into from
Jun 4, 2021
Merged

Shim dbt-expectations macros #47

merged 18 commits into from
Jun 4, 2021

Conversation

alieus
Copy link
Contributor

@alieus alieus commented May 27, 2021

No description provided.

dataders added a commit that referenced this pull request May 30, 2021
@dataders
disable until #47
48a1ec6
dataders added a commit that referenced this pull request May 30, 2021
@dataders
disable until #47
521a656
@dataders dataders mentioned this pull request May 31, 2021
Closed
@dataders dataders force-pushed the shim_dbt-expectations_macros branch from 62e83fd to 2bf161d Compare June 2, 2021 23:38
@dataders dataders mentioned this pull request Jun 2, 2021
Merged
@alieus alieus marked this pull request as ready for review June 2, 2021 23:51
dataders
dataders approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very excited to have this package out! on my machine and on CircleCI it's failing with the NoneType error, but let's merge this and revisit down the line.

dataders
dataders reviewed Jun 3, 2021
View reviewed changes
macros/dbt_expectations/schema_tests/_generalized/equal_expression.sql Outdated
{%- set compare_group_by = group_by if not compare_group_by else compare_group_by -%}

{%- set n_cols = group_by|length %}
Copy link
Contributor

@dataders dataders Jun 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b-per maybe this is the needed change? I'm 80% sure we tried this though to no avail...

Suggested change
{%- set n_cols = group_by|length %}
{%- set n_cols = (group_by|length) if group_by else 0 %}

@alieus alieus merged commit 28822f1 into main Jun 4, 2021
@dataders dataders deleted the shim_dbt-expectations_macros branch November 12, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataders dataders dataders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alieus @dataders