-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
Hi Kyle, Thanks for the interest. Looks very good to me. One thing I couldn't get is why the use stricts are gone. Can you please explain it? |
I also forked your plunk here and added aside close functionality to the ok/cancel buttons, since there is no backdrop to close. |
Sure. You can hit esc. to close them, but I just wanted to test it w/o backdrop functionality. I removed the use strict directives because they were in the global scope, and they were trying to tell all of my other code to be strict. I didn't put it back in but if you wanted to, you could put it inside a closure like so: (function() {
"use strict";
)(); |
added vertical asides (top/bottom)
I always used it on global scope. Of course, there should be a closure for the sake of portability. |
No problem! I was wondering why my code was breaking - turns out that it was interfering with d3 (since d3 does some things that don't pass in strict mode). |
Hey, I just wanted to let you know that your plunk doesn't work. |
I just noticed it with another browser. It was ok on Safari however it's broken on Chrome (like a very older version). Thanks again 👍 |
No problem, thank you for making this! |
I've found your library and I like it a lot, but I also needed an aside (so to speak) but on the bottom. I figured I'd add one on the top as well just in case someone might need that as well. Here's the plunk I've updated the readme with: http://plnkr.co/edit/MoHT8o31AP3xDwF8a9oD?p=preview