Skip to content
This repository has been archived by the owner on Apr 18, 2020. It is now read-only.

Add commonjs support and metadata to package.json #28

Merged
merged 2 commits into from
Sep 15, 2015
Merged

Add commonjs support and metadata to package.json #28

merged 2 commits into from
Sep 15, 2015

Conversation

mattlewis92
Copy link
Contributor

Closes #27

@dbtek
Copy link
Owner

dbtek commented Sep 15, 2015

Oh, that was fast! Thanks @mattlewis92.

I don't know about the style field but, index.js should be in the main field value, shouldn't it?

@dbtek
Copy link
Owner

dbtek commented Sep 15, 2015

Actually as it's name is 'index.js' there is no necessity for main field. browser field is for bundlers only I guess.

@mattlewis92
Copy link
Contributor Author

Yup browser is a non standardised field but used by the main module bundlers (i.e. webpack + browserify) to indicate that this is the entry point for a browser module.

@dbtek
Copy link
Owner

dbtek commented Sep 15, 2015

It's ok then. Adding .npmignore file is the only thing to do before merge.
Contents would be:

src
test
Gruntfile.js
bower.json
karma.conf.js
.jshintrc

@mattlewis92
Copy link
Contributor Author

Good shout, I've added that now :)

dbtek added a commit that referenced this pull request Sep 15, 2015
Add commonjs support and metadata to package.json
@dbtek dbtek merged commit 34c059b into dbtek:master Sep 15, 2015
@dbtek
Copy link
Owner

dbtek commented Sep 15, 2015

Thanks a lot @mattlewis92. Appreciated ☺️

@mattlewis92
Copy link
Contributor Author

NP, happy to help, thanks for getting back to me so quickly! 😄

@dbtek dbtek mentioned this pull request Sep 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants