This repository has been archived by the owner on Apr 18, 2020. It is now read-only.
Fix css class specificity with ui bootstrap 1.3.3 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed by adding .modal class to css selectors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
i noticed that the ngAside lib was broken when used with the latest ui bootstrap.
The problem I had occured when the modal was animating out i.e. without the ".in" css class.
When the ".in" class is removed ngAside css selectors were no longer the most specific selector.
The fix was simply to add ".modal" to all selectors where ngAside styles need to apply.